Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ModelPicker not snapshotted and refactor ModelPicker #1122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

System233
Copy link

@System233 System233 commented Feb 22, 2025

Description

Bug Fixes:

  1. Fixed an issue where ModelPicker was still referencing ExtensionStateContext and was not properly snapshotted.
  2. Corrected a type constraint issue where openAiCustomModelInfo was incorrectly mapped to the undeclared key: openAiModelInfo.

User Experience Improvements:

  1. Simplified the implementation of CustomModel input, making inputs more convenient and user-friendly.
  2. Added an auto-complete feature to the ModelId input field.

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Fix and refactor ModelPicker to improve snapshotting and add auto-complete feature.

  • Bug Fixes:
    • Fix ModelPicker not being properly snapshotted and remove references to ExtensionStateContext.
    • Correct type constraint for openAiCustomModelInfo in ApiOptions.tsx.
  • Refactoring:
    • Consolidate multiple model picker components into a single ModelPicker component in ModelPicker.tsx.
    • Remove OpenAiModelPicker, OpenRouterModelPicker, GlamaModelPicker, RequestyModelPicker, and UnboundModelPicker.
  • Features:
    • Add auto-complete feature to ModelPicker using Combobox in ModelPicker.tsx.
    • Simplify CustomModel input handling in ApiOptions.tsx.
  • Testing:
    • Update ModelPicker.test.tsx to test new auto-complete functionality and refactored ModelPicker behavior.

This description was created by Ellipsis for be47c8c. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Feb 22, 2025

⚠️ No Changeset found

Latest commit: 8aced86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. bug Something isn't working labels Feb 22, 2025
@System233 System233 changed the title fix: ModelPicker not snapshotted and refactoring ModelPicker fix: ModelPicker not snapshotted and refactor ModelPicker Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant