-
Notifications
You must be signed in to change notification settings - Fork 3
Add a "Request Rename" action menu item. #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Huh.... was testing what an average user would see, and was surprised to see Users can move pages now? Did an upgrade remove this block? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh.... was testing what an average user would see, and was surprised to see Users can move pages now? Did an upgrade remove this block?
Normal users have always had permission to move pages. By default, normal users should be able to do anything that might be valuable for an individual content contributor to do, and renaming a page certainly falls under that. Locations are special cases where renaming is much more likely to mess things up, but it is possible for normal users to perform this operation correctly (even if not practically very likely).
if ( $user->isRegistered() && $title->getNamespace() === NS_MAIN ) { | ||
$links['actions']['request-rename'] = [ | ||
'text' => 'Request Rename', | ||
'href' => 'Request_Rename', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should certainly populate this page with something before deploying this change. I think the content of that page can initially be whatever we would tell people today -- "make a request on Facebook" sounds good, though this exists as well probably worth linking to. I think its value is more for transparency (showing people how the system works rather than making it a black box that only special elite people are allowed to touch) than practicality since I don't expect many people to pursue the manual renaming route.
My idiosyncratic nit is that I don't like Title Case for things that aren't proper-noun names so I would prefer Request_rename, though the rational side of my brain tells me I should accept either capitalization :) I mention it here to satisfy the other part of my brain.
All of these sound like great options to me and I would expect a progression from option 1 to option 3 as time and resources allow us to develop the more sophisticated solutions. |
I feel a lot of requests posted in the FB group start with "I couldn't see a way of doing it myself, so I'm asking here...".
So lets add a "Request Rename" option.
e.g. (albeit it logged in as an admin currently).
What this link direct to is up for debate.
Simplest would be just a static wiki page saying "posting FB and/or discord", however it could be a more intelligent form which uses $user, $pagename, and an input box to generate a request for them.
It could also in the longer term call out to a safe renaming system (maybe https://github.com/RopeWiki/ropewiki-python-renamer as a service) and do it automatically.
Thoughts?