Add option to control intermediate dumping in BackrubProtocol #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially with XML (where the Backrub protocol is part of a more extensive protocol), you don't necessarily want an unconditional dumping of the last & low results from the Backrub stage. This commit adds an XML option which will allow the dumping of the poses (old behavior), but turns it off by default. This only changes XML usage -- I didn't change how the backrub application behaves. Changes to the backrub_interface_ddG integration test is expected.
roccomoretti
added
ready_for_review
woodsh17
approved these changes
May 30, 2025
Member
woodsh17
left a comment
woodsh17
left a comment
There was a problem hiding this comment.
@roccomoretti Do you know if there are any tests that use BackrubProtocol outside of RosettaScripts to make sure that behavior stays the same? Also, do we need to test that if dump_poses_ is set to true that the PDBs are in fact dumped?
Member
Author
|
Yes, there are several tests which use backrub applications. (Most notably the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially with XML (where the Backrub protocol is part of a more extensive protocol), you don't necessarily want an unconditional dumping of the last & low results from the Backrub stage. This PR adds an XML option which will allow the dumping of the poses (old behavior), but turns it off by default. This only changes XML usage -- I didn't change how the backrub application behaves.
Changes to the backrub_interface_ddG integration test is expected.