metainfo: set length value to actual value - #2
Merged
Conversation
... and stop it from showing up in Flathub's Mobile Collection before it is actually ready to work on mobile devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
First let me thank you for creating this nice app!
Unfortunately, the metadata is wrongly advertising the app as fitting screens that are 360 logical pixels wide. 360px is kind of the "magical width" for #LinuxMobile (e.g., on devices running postmarketOS, Mobian or Droidian), see as this list I've compiled shows.
The current release Smashed Pumpkin is unfortunately wider in reality (measured with Length:
To solve this, adjusting the metadata value from 360px to the actually measured value as this PR does (or removing the line and the line before and after) would be enough.
If mobile support is in scope, I'll happily help with testing. IMHO, you don't necessarily need a phone even to develop for Linux Mobile support, any touchscreen device and the length app should go most of the way.
Hope this helps!
Cheers,
Peter