Define methods on dynamic module#703
Merged
sunny merged 5 commits intoRubyMoney:mainfrom Dec 21, 2025
Merged
Conversation
Currently you cannot override the generated methods and access super ie: ```ruby monetize :price_cents def price=(value) # stuff super # NoMethodError end ``` This happens because the method is defined on the class directly so their is no super method to call. A solution today is to create an alias (`alias :old_price= :price=`) before overriding the method as is recommending in issue RubyMoney#507. Instead, a new module can be created, included into the class, and the methods defined on it allowing `super` to work as expected.
sunny
previously approved these changes
Jul 3, 2024
Member
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
Neat! Can you add an entry to the CHANGELOG as well?
sunny
previously approved these changes
Jul 4, 2024
Member
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
Tests don’t seem to run though, but it doesn’t seem to be linked to your changes 🤔
Contributor
Author
|
Looks like #698 also had issues with sqlite3 and added a |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
sunny
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you cannot override the generated methods and access super ie:
This happens because the method is defined on the class directly so their is no super method to call. A solution today is to create an alias (
alias :old_price= :price=) before overriding the method as is recommending in issue #507.Instead, a new module can be created, included into the class, and the methods defined on it allowing
superto work as expected.