Add method for cents-based check#1125
Merged
yukideluxe merged 9 commits intoRubyMoney:mainfrom Jul 9, 2025
Merged
Conversation
Contributor
Author
|
@semmons99 can we get this one in? |
Member
|
yes. we just need help getting CI/CD functioning again. something broke somewhere along the line on all RubyMoney org repos |
sunny
reviewed
Jun 26, 2025
Member
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
Can you add an entry to the Changelog and an example in the Readme as well? 🙏🏻
Sija
reviewed
Jun 29, 2025
Contributor
Author
Member
|
Thank you! If we wanted to add it to the README we could go for a new line under Currency like so: currency = Money.from_cents(1000, "USD").currency
currency.iso_code # => "USD"
currency.name # => "United States Dollar"
currency.cents_based? # => trueI don’t think it needs a whole paragraph of explanation, but can be helpful for people looking for something similar. |
Contributor
Author
|
@sunny done! |
yukideluxe
approved these changes
Jul 9, 2025
Member
yukideluxe
left a comment
yukideluxe
left a comment
There was a problem hiding this comment.
💪🏻 I'll edit the CHANGELOG to include this in the upcoming 7.0 release ✌🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a useful addition to the currency class. Let me know what you think. Happy to add more or close depending on feedback.