Fix MGA (Malagasy Ariary) to be a zero-decimal currency#1127
Fix MGA (Malagasy Ariary) to be a zero-decimal currency#1127cade merged 1 commit intoRubyMoney:mainfrom
Conversation
|
@cade can you check this one out? Thoughts? |
cade
left a comment
There was a problem hiding this comment.
Yep. Thanks for the Stripe/Wikipedia links!
|
@cade thanks! |
|
Where is the proof that since May 2023, the 1/5 unit is effectively obsolete? According to ISO-4217 it is still valid. The fact that Stripe treats it as a zero-decimal currency should not trigger this change? Wiki mention it but without any reference. |
|
@RemyDuijkeren true that wiki entry doesn't have a proper reference. Should we revert this change then? I couldn't find any other reliable information about this |
|
@mapreal19 I don't use RubyMoney so I can't say anything about which direction to take (I maintain the .NET counterpart, so there for my interest in RubyMoney). I also couldn't find any reliable information about this, so I personally lean more on what ISO is saying. |
|
@cade what's your opinion on this? |
|
Firstly, I absolutely do not consider myself the final source of truth for the RubyMoney gem's formatting decisions. I have also experienced first hand situations where lagging ISO standard updates in other areas cause real bugs/errors/pain. That said, I tried to go down the Wikipedia article's edit history rabbit hole. There's an edit at least as far back as 2021 claiming that the iraimbilanja is "effectively obsolete." I have no first-hand experience with this currency, and cannot confidently attest to the truth of this claim. However, I do generally trust Wikipedia references for currency details, even if there's not extensive citations. I have no horse in this race, but I'm inclined to personally lean into seemingly real-world usage (as it appears Stripe has done) over dying on the ISO hill until the standard is updated. That said, if anyone else disagrees and reverts this, I will have zero objections. 🤷 |
|
My personal experience is that when people talk about 'this is not being used anymore' they often talk about cash transactions. Like the 1- and 2-cent EUR in The Netherlands. But the fact that Stripe is not doing it for financial transactions is a strong indicator that maybe it is really not used overall anymore. |
According to Stripe's documentation (https://docs.stripe.com/currencies#zero-decimal), MGA is included in their list of zero-decimal currencies, and this change ensures the Money gem correctly formats MGA amounts without decimal places.
Also from the Wikipedia entry: