stop setting USD as default currency#1143
Merged
yukideluxe merged 3 commits intomainfrom Jul 23, 2025
Merged
Conversation
yukideluxe
commented
Jul 13, 2025
| end | ||
|
|
||
| it_behaves_like 'instance with custom bank', :+, Money.new(1) | ||
| it_behaves_like 'instance with custom bank', :+, -> { Money.new(1) } |
Member
Author
There was a problem hiding this comment.
To simplify the changes, I am setting the default currency as USD in a before suite :each (EDITED 6c1d7c7) callback. That said, these initializations were failing because they run on loading the spec before the callback is run so they need to be lazy loaded. I have very little knowledge about rspec, and I used Copilot to figure out the error. I could have passed the currency here instead, but I think this is more proper? 🤔
yukideluxe
force-pushed
the
jl-remove-infinite-precision-deprecation
branch
from
c5a365d to
ef3ed15
Compare
yukideluxe
force-pushed
the
jl-stop-setting-default-currency
branch
from
d2e0005 to
a43e502
Compare
Base automatically changed from
jl-remove-infinite-precision-deprecation
to
main
July 22, 2025 17:25
Co-authored-by: Sunny Ripert <sunny@sunfox.org>
yukideluxe
force-pushed
the
jl-stop-setting-default-currency
branch
3 times, most recently
from
61c1c5f to
aeb1f19
Compare
yukideluxe
force-pushed
the
jl-stop-setting-default-currency
branch
from
aeb1f19 to
6c1d7c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @RubyMoney/core and everyone watching this 👀
Time for another round of deprecation cleanup 🧹🧹🧹
Now that this PR has been merged, we can stop setting USD as the default currency, which was already anticipated back in 2019.
It's about time we finally pull the trigger 💪🏻