Add Money#to_nearest_cash_value to return a rounded Money instance to the smallest denomination#1146
Merged
yukideluxe merged 5 commits intoRubyMoney:mainfrom Jul 24, 2025
Merged
Conversation
…to the smallest denomination This new method allows you to get a new Money instance rounded to the smallest denomination. Closes RubyMoney#1131
sunny
force-pushed
the
add-to_nearest_cash_value
branch
from
b97ff87 to
52b15e9
Compare
yukideluxe
previously approved these changes
Jul 23, 2025
Member
yukideluxe
left a comment
yukideluxe
left a comment
There was a problem hiding this comment.
I really like this! Just a note about the link to BigDecimal ROUND_MODE that I updated in one of my PRs, it seems that git did not detect a conflict there 😳
Member
Author
It did, I just add the wrong one in my conflicts 😅 Thank you for the swift merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new method allows you to get a new Money instance rounded to the smallest denomination.
Closes #1130
Allows us to simplify:
to:
Ideally the
#round_to_nearest_cash_valueshould have always returned an instance to act like the#roundmethod. Introducing a new method avoids breaking previous code.