Not allow divide by zero #1148
Open
Not allow divide by zero #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny
reviewed
Jul 23, 2025
| # @example | ||
| # 2 * Money.new(10) #=> #<Money @fractional=20> | ||
| def coerce(other) | ||
| raise TypeError, "Cannot divide Numeric by Money" if caller_locations(1,1).first.label == "/" |
There was a problem hiding this comment.
Relying on the caller locations may not be the most robust way to handle this and looks like it could imply a slight performance penalty. Would there be another way to do this?
| if value.is_a?(self.class) | ||
| fractional / as_d(value.exchange_to(currency).fractional).to_f | ||
| exchanged = value.exchange_to(currency) | ||
| raise ZeroDivisionError, "divided by Money(0)" if exchanged.zero? |
There was a problem hiding this comment.
Could you add specs for each of these raised errors? 🙏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1109