Fix O(n2) to be O(n) for generate method#1149
Merged
yukideluxe merged 1 commit intoRubyMoney:mainfrom Jul 23, 2025
Merged
Conversation
yukideluxe
approved these changes
Jul 23, 2025
| result = [] | ||
| remaining_amount = amount | ||
|
|
||
| parts_sum = parts.sum |
Member
There was a problem hiding this comment.
love the change from inject to sum 😍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruby 3.3.3 (2024-06-12 revision f1c7b6f435) [arm64-darwin23] Warming up -------------------------------------- generate_old 144.000 i/100ms generate_new 570.000 i/100ms Calculating ------------------------------------- generate_old 1.441k (± 0.7%) i/s (693.93 μs/i) - 4.464k in 3.097879s generate_new 5.576k (± 1.4%) i/s (179.34 μs/i) - 17.100k in 3.067351s Comparison: generate_new: 5576.0 i/s generate_old: 1441.1 i/s - 3.87x slower