Skip to content

Lint: Fix Style/FileWrite #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunny merged 2 commits into from
Dec 19, 2025
+5 −17
Merged

Lint: Fix Style/FileWrite #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f590b
Lint: Fix Style/FileWrite
sunny Dec 19, 2025
530a52b
Merge branch 'main' into lint-fix-Style/FileWrite
sunny Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .rubocop_todo.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/money/bank/variable_exchange.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def export_rates(format, file = nil, _opts = {})
s = FORMAT_SERIALIZERS[format].dump(rates)

unless file.nil?
File.open(file, "w") { |f| f.write(s) }
File.write(file, s)
end

s
Expand Down
2 changes: 1 addition & 1 deletion lib/money/currency/loader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class Money
class Currency
module Loader
DATA_PATH = File.expand_path("../../../../config", __FILE__)
DATA_PATH = File.expand_path("../../../config", __dir__)

class << self
# Loads and returns the currencies stored in JSON files in the config directory.
Expand Down
8 changes: 3 additions & 5 deletions spec/bank/variable_exchange_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,13 +200,11 @@

context "with :file provided" do
it "writes rates to file" do
f = instance_double(IO)
allow(File).to receive(:open).with('null', 'w').and_yield(f)
allow(f).to receive(:write)
allow(File).to receive(:write)

bank.export_rates(:json, 'null')
bank.export_rates(:json, "null")

expect(f).to have_received(:write).with(JSON.dump(expected_rates))
expect(File).to have_received(:write).with("null", JSON.dump(expected_rates))
end
end

Expand Down