Draft
Conversation
* chore: remove not needed rumbleruntimeconfiguration parameter from getStaticContextForRuntime * chore(visitors): remove not needed rumbleruntimeconfiguration params * chore: mvn spotless:apply * fix: unshadow static context in a few expressions
…config - Add RumbleRuntimeConfiguration xml-version CLI handling and accessors - Decode string literals with unescapeXml after JSON unescape (TranslationVisitor) - Validate codepoints with intValueExact and XML character rules in CodepointsToStringFunctionIterator Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR tightens codepoint validation to respect XML version configuration. Changes have been extracted from #1409.
Changelog
CodepointsToStringFunctionIteratorto:CodepointNotValidExceptionfor out-of-range or non-integral values.RumbleRuntimeConfigurationso codepoint acceptance can be tuned for XML 1.0 vs 1.1 (especially for C0/C1 control characters).xml-versiondependencies).