core: Add -frust-compile-core flag #4344
Open
+60
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
force-pushed
the
compile-core-flag
branch
from
737cee1 to
2156b7c
Compare
Add a specific flag for compiling core which changes compiler generated paths. This is important for derives, and especially for core, where we want to implement crate::marker::Copy rather than core::marker::Copy. gcc/rust/ChangeLog: * lang.opt: Add -frust-compile-core option. * ast/rust-ast-builder.h: Add get_path_start method which depends on -frust-compile-core * ast/rust-ast-builder.cc (Builder::discriminant_value): Use it. * expand/rust-derive-debug.cc (DeriveDebug::stub_debug_fn): Likewise. * expand/rust-derive-default.cc (DeriveDefault::default_call): Likewise. * expand/rust-derive-eq.cc (DeriveEq::assert_param_is_eq): Likewise. * expand/rust-derive-hash.cc (DeriveHash::hash_call): Likewise. (DeriveHash::hash_fn): Likewise. * expand/rust-derive-ord.cc (DeriveOrd::cmp_call): Likewise. (DeriveOrd::cmp_fn): Likewise. (DeriveOrd::make_equal): Likewise. (DeriveOrd::recursive_match): Likewise. * expand/rust-expand-format-args.cc (format_arg): Likewise. (expand_format_args): Likewise.
CohenArthur
force-pushed
the
compile-core-flag
branch
from
2156b7c to
6624978
Compare
P-E-P
reviewed
Jan 20, 2026
| Rust Var(flag_unused_check_2_0) | ||
| Use the new unused variable check implementation. | ||
|
|
||
| frust-compile-core |
Member
There was a problem hiding this comment.
We could maybe rely on #[no_core] instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a specific flag for compiling core which changes compiler generated paths. This is important for derives, and especially for core, where we want to implement crate::marker::Copy rather than core::marker::Copy.
gcc/rust/ChangeLog: