testsuite: Adds test from issue 1245#4369
Merged
P-E-P merged 1 commit intoRust-GCC:masterfrom Jan 12, 2026
Merged
Conversation
P-E-P
requested changes
Jan 9, 2026
| let b = a as *const str; | ||
| let c = b as *const i8; | ||
| unsafe { | ||
| printf(c); |
Member
There was a problem hiding this comment.
We probably need to put this within the execute directory and match the output to ensure the minus is indeed kept correctly.
Contributor
Author
There was a problem hiding this comment.
Done !
Waiting for pipeline to pass
Should I keep the first commit or not ?
Collaborator
There was a problem hiding this comment.
You should probably squash them together
Added the test from the issue 1245. Fixes GCC-Rust/gccrs#1245 gcc/testsuite/ChangeLog: * rust/execute/issue-1245.rs: New test. Signed-off-by: lenny.chiadmi-delage <lenny.chiadmi-delage@epita.fr>
P-E-P
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1245
As the issue as already been solved, i added the test from the issue.
The issue can be closed.