Use pretty printer instead ofcall to open_memstream#4487
Open
P-E-P wants to merge 1 commit intoRust-GCC:masterfrom
Open
Use pretty printer instead ofcall to open_memstream#4487P-E-P wants to merge 1 commit intoRust-GCC:masterfrom
P-E-P wants to merge 1 commit intoRust-GCC:masterfrom
Conversation
Collaborator
|
How should authorship/sign-off be handled? |
Contributor
Signed-off-by: Andrew Pinski andrew.pinski@oss.qualcomm.com |
open_memstream is a POSIX call which is not available on mingw platform. gcc/rust/ChangeLog: * typecheck/rust-tyty.cc (generate_tree_str): Remove opem_memstream and print_generic_stmt call with call to dump_generic_node. Signed-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>
P-E-P
force-pushed
the
mingw_open_memstream
branch
from
c7c1ace to
ca3fe7c
Compare
Member
Author
Initially I put andrew as the author of the commit, I wasn't sure if andrew has any fsf attribution hence the missing sign off. With andrew's recent confirmation I added a sign-off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove open_memstream call. Code from @pinskia
Fixes #4483