Skip to content

ascon-aead: migrate tests to blobby #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025
Merged

ascon-aead: migrate tests to blobby #675

merged 2 commits into from
Mar 23, 2025

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Mar 22, 2025

The new test uses blobby format which will be used by the new new_pass_test! macro (see RustCrypto/traits#1803).

@newpavlov
Copy link
Member Author

@sebastinas
Do you remember provenance of the KATs?

It also looks like these Wycheproof vectors are wrong? For key: "b67b1a6efdd40d37080fbe8f8047aeb9", "iv": "fa294b129972f7fc5bbd5b96bba837c9", "aad" : "", and "msg" : "" from our implementation I get tag equal to dc1acf9d5a18658c39b1337c0e02c07d, while the first Wycheproof vector expects 47648fcad24982437276b8d5901f812b.

@newpavlov
Copy link
Member Author

newpavlov commented Mar 23, 2025

Re-generated tests from the reference implementation vectors.

@newpavlov newpavlov merged commit 164f6f1 into master Mar 23, 2025
108 checks passed
@newpavlov newpavlov deleted the ascon-aead/tests branch March 23, 2025 00:18
@sebastinas
Copy link
Contributor

If you have questions, please at least give me time to answer them before you merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants