chore(deps): bump digest pin #185
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
baloo
force-pushed
the
baloo/digest-pin
branch
3 times, most recently
from
d3c9004 to
526c47d
Compare
baloo
commented
May 10, 2025
hmac/src/optim.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl<D: EagerHash> FixedOutputCore for HmacCore<D> { | ||
| impl<D: EagerHash> FixedOutput for Hmac<D> { |
There was a problem hiding this comment.
I'm not exactly happy with this change, I think this removes some amount of optimization as we can't access the inner FixedOutputCore
cc @newpavlov
There was a problem hiding this comment.
It's why we have the CoreProxy trait. For the optimized implementation you should add bounds on D::Core and use it in the generic implementation. We may need to add a from_core method to it (which previously was an inherent method on CoreWrapper). I planned to do it a bit later.
digest doesn't provide `std` feature anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
digest doesn't provide
stdfeature anymoreDepends;
digest::newtype!hashes#678