impl ConditionallyNegatable for BoxedUint
#795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not seeing a https://docs.rs/subtle/latest/subtle/trait.ConditionallyNegatable.html |
|
The Copy bound comes from T having to be ConditionallySelectable. On 14 Mar 2025, at 16:14, Tony Arcieri ***@***.***> wrote:
I'm not seeing a Copy bound on subtle::ConditionallyNegatable?
https://docs.rs/subtle/latest/subtle/trait.ConditionallyNegatable.html—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
tarcieri left a comment (RustCrypto/crypto-bigint#795)
I'm not seeing a Copy bound on subtle::ConditionallyNegatable?
https://docs.rs/subtle/latest/subtle/trait.ConditionallyNegatable.html
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@dvdplm that's to leverage the blanket impl though. You should still be able to impl |
dvdplm
changed the title
dvdplm
changed the title
|
Ah, I see what you mean now! Better now? |
tarcieri
reviewed
Mar 18, 2025
| @@ -926,7 +926,7 @@ pub trait Monty: | |||
| /// Allows one to perform inplace multiplication without allocations | |||
| /// (important for the `BoxedUint` case). | |||
| /// | |||
| /// NOTE: You will be operating with Montgomery represntations directly, | |||
| /// NOTE: You will be operating with Montgomery representations directly, | |||
There was a problem hiding this comment.
Bleh, we should set up typos-action
tarcieri
approved these changes
Mar 18, 2025
tarcieri
changed the title
ConditionallyNegatable for BoxedUint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an equivalent to
subtle'sConditionallyNegatetrait without theCopyrequirement.