sm2: Fix heap allocation #1099
Open
sm2: Fix heap allocation #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Mar 14, 2025
|
@MaxKingPor sorry this PR went by the wayside, can you rebase it and we can get it merged? |
MaxKingPor
force-pushed
the
master
branch
2 times, most recently
from
6bc5abd to
8a07d9e
Compare
tarcieri
reviewed
Mar 18, 2025
tarcieri
reviewed
Mar 19, 2025
tarcieri
reviewed
Mar 19, 2025
| use super::{Cipher, Mode, encrypting::EncryptingKey, kdf, vec}; | ||
| /// Represents a decryption key used for decrypting messages using elliptic curve cryptography. | ||
| #[derive(Clone)] | ||
| pub struct DecryptingKey { |
There was a problem hiding this comment.
I'd prefer these names be retained, as they're more consistent with our other crates which identify key types by function
tarcieri
reviewed
Mar 19, 2025
| use super::{Cipher, kdf}; | ||
|
|
||
| /// Decrypt messages using elliptic curve cryptography. | ||
| pub trait EcDecrypt<C> |
There was a problem hiding this comment.
Not sure why a trait is necessary where when it has only one impl. What's the intended use case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sm2 heap allocation