der: add AnyCustomClassExplicit/AnyCustomClassImplicit#1747
Closed
dishmaker wants to merge 1 commit intoRustCrypto:masterfrom
Closed
der: add AnyCustomClassExplicit/AnyCustomClassImplicit#1747dishmaker wants to merge 1 commit intoRustCrypto:masterfrom
AnyCustomClassExplicit/AnyCustomClassImplicit#1747dishmaker wants to merge 1 commit intoRustCrypto:masterfrom
Conversation
dishmaker
commented
Mar 28, 2025
| fn tag(&self) -> Tag { | ||
| self.tag_number | ||
| .custom_class(self.class, self.constructed) | ||
| .expect("class not to be Universal") |
Contributor
Author
There was a problem hiding this comment.
I don't know how to get rid of this unwrap/expect
dishmaker
commented
Mar 28, 2025
|
|
||
| impl<'a, T> AnyCustomClassImplicit<T> | ||
| where | ||
| T: Tagged + DecodeValue<'a> + 'a, |
Contributor
Author
There was a problem hiding this comment.
TODO replace with IsConstructed from another PR
dishmaker
commented
Mar 28, 2025
|
|
||
| impl<T> EncodeValue for AnyCustomClassExplicit<T> | ||
| where | ||
| T: EncodeValue + Tagged, |
Contributor
Author
There was a problem hiding this comment.
TODO maybe T: Encode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for:
EncodeValue,DecodeValuetrait requirements forEXPLICIT#1745Encode,Decode,Taggedtraits requirements forIMPLICIT#1746Not the best solution, but a proof-of-concept of internal API that
ContextSpecificwrapper would use.