Skip to content

digest: remove AssociatedOid blanket impls for wrappers #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

digest: remove AssociatedOid blanket impls for wrappers #1810

merged 2 commits into from
Apr 7, 2025
+24 −66

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Apr 7, 2025 •
edited
Loading

Together with #1799 users would need to implement AssociatedOid manually on created newtypes.

Also replaces feature = "const-oid" with feature = "oid" in some places.

@newpavlov newpavlov requested a review from tarcieri April 7, 2025 13:03
@tarcieri
Copy link
Member

tarcieri commented Apr 7, 2025

Seems like you could completely remove the const-oid dependency from digest at this point?

The trait impl is easy enough to write by hand

@newpavlov
Copy link
Member Author

I would love to do it, but we still have the DynDigestWithOid trait. Should I remove it as well?

tarcieri
tarcieri approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good point, never mind!

@newpavlov newpavlov merged commit c48ea2a into master Apr 7, 2025
10 checks passed
@newpavlov newpavlov deleted the digest/oid branch April 7, 2025 13:12
@baloo
Copy link
Member

baloo commented May 7, 2025 •
edited
Loading

This kind of merged a bit early, without #1799 we can't bump the git pin anymore.

Missed RustCrypto/hashes#678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newpavlov @tarcieri @baloo