Skip to content

Allow BatchInvert with zero elements #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jun 2, 2025

This caused panics in the BatchNormalize implementation of primeorder. I don't know why we would disallow zero elements here.

Alternatively I could add a check for zero elements in BatchNormalize, but again: I wouldn't know why we would disallow zero elements.

@tarcieri tarcieri merged commit 57c9e79 into RustCrypto:master Jun 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants