cpubits: change cfg(enable_64_bit = ...) syntax#1426
Merged
Conversation
The new syntax is used in the title, and feels a little more idiomatic than the old syntax, which was `cfg(enable_64bit(...))`. It's also changed not to be implicitly `any(...)` to feel a little more WYSIWYG, i.e. it now uses an explicit `any` rather than having an extra comment which takes up a whole line to say it's implicitly `any`.
tarcieri
force-pushed
the
cpubits/change-enable-64-bit-syntax
branch
from
4a5c747 to
9a6586a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new syntax is used in the title, and feels a little more idiomatic than the old syntax, which was
cfg(enable_64bit(...)).It's also changed not to be implicitly
any(...)to feel a little more WYSIWYG, i.e. it now uses an explicitanyrather than having an extra comment which takes up a whole line to say it's implicitlyany.