-
Notifications
You must be signed in to change notification settings - Fork 29
[WIP] Rust 2024 #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Phosphorus-M
wants to merge
907
commits into
main
Choose a base branch
from
only-new-async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Rust 2024 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3999
Very small clarification on if let
The pedantry is accurate, but since we can just drop this entirely, it will cut the potential distraction for readers who might get hung up on it otherwise! Fixes #3818
Drop a pedantry-triggering sentence about IEEE-754
Link to tests section of rustc book for `cargo test -- --help` docs
Rephrase for clarity
Ch. 17: fix some wording issues
Fix confusion between variable `hello` and string `"hello"`
Fixes #3773.
Fix a couple inverted uses of “shadowed”
Follow-on for #3773 and #4121: I missed how the rest of this paragraph also had “shadowed” inverted!
Fix more inverted uses of “shadowed”
Multiple people have filed or commented on issues over the past few years (at least #3782, #4101, #4090, and #3921; and possibly others I have not found) because seeing “compare” here led them to jump ahead to the conversion (in the next paragraph). The text was technically correct as it stood, but since it kept derailing/hijacking people’s train of thought, tweaking it seems helpful.
Ch. 2: tweak a phrase to avoid derailing some readers
Adding reference to an actively maintained Spanish translation
This appears to still work with pulldown-cmark, but not necessarily in all renderers, and (more to the point at present) is not compatible with dprint, which does not like the line wrapping that way!
No more need to manually wrap lines? GREAT.
…n multiple chapters
⚡ Cloudflare Pages Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early translation of the new chapters from the PR:
rust-lang/book#3909
@RustLangES/content-team
@RustLangES/traductores