Restore previous convert visitor approach to correctly bind columns #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of attempting to get away without using reflection (and then resorting to it anyways), this setup reuses the previously used approach to updating the SelectExpression. Due to internal changes that means a slightly different invocation of the GenerateOuterColumnAccessor preceded by a reflection-based restoration of the _sqlAliasManager that is needed for the call of PushDownIntoSubQuery. Future versions of .NET may make this obsolete by removing the use of SqlAliasManager within SelectExpression entirely, but that's a future concern.
This was referenced Apr 2, 2025
|
@Rwing Do you have time to merge this PR? |
|
any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of attempting to get away without using reflection (and then resorting to it anyways), this setup reuses the previously used approach to updating the SelectExpression. Due to internal changes that means a slightly different invocation of the GenerateOuterColumnAccessor preceded by a reflection-based restoration of the _sqlAliasManager that is needed for the call of PushDownIntoSubQuery. Future versions of .NET may make this obsolete by removing the use of SqlAliasManager within SelectExpression entirely, but that's a future concern.
This fixes both the projection behavior of Net9 as well as non-root offset and limit uses for net8 as introduced in #17.
@Rwing sorry it took so long to get this fix done...