Fix security, algorithm, and CI issues from repo audit

.env.example

@@ -54,6 +54,14 @@ ACCURACY_SCHEDULER_ENABLED=true
 MARKET_TZ=Asia/Kolkata
 MARKET_EXCHANGE=NSE
 
+# ── Backend API auth (optional) ───────────────────────────────────────────────
+# If set, every request to the FastAPI backend must carry
+# `Authorization: Bearer <token>` (except GET /health). Leave empty for the
+# default localhost-only workflow. Set this if the backend is reachable
+# beyond localhost (e.g. behind a reverse proxy). Does NOT cover the
+# /accuracy/ws WebSocket — see UI/backend/auth.py.
+BUCK_API_AUTH_TOKEN=
+
 # ── MCP server ────────────────────────────────────────────────────────────────
 # HTTP port for the standalone MCP server (`python -m mcp_server.runner`).
 MCP_HTTP_PORT=8765

.github/workflows/codeql.yml

@@ -1,103 +1,103 @@
-# # For most projects, this workflow file will not need changing; you simply need
-# # to commit it to your repository.
-# #
-# # You may wish to alter this file to override the set of languages analyzed,
-# # or to provide custom queries or build logic.
-# #
-# # ******** NOTE ********
-# # We have attempted to detect the languages in your repository. Please check
-# # the `language` matrix defined below to confirm you have the correct set of
-# # supported CodeQL languages.
-# #
-# name: "CodeQL Advanced"
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL Advanced"
 
-# on:
-#   push:
-#     branches: [ "main" ]
-#   pull_request:
-#     branches: [ "main" ]
-#   schedule:
-#     - cron: '38 10 * * 1'
+on:
+  push:
+    branches: [ "main" ]
+  pull_request:
+    branches: [ "main" ]
+  schedule:
+    - cron: '38 10 * * 1'
 
-# jobs:
-#   analyze:
-#     name: Analyze (${{ matrix.language }})
-#     # Runner size impacts CodeQL analysis time. To learn more, please see:
-#     #   - https://gh.io/recommended-hardware-resources-for-running-codeql
-#     #   - https://gh.io/supported-runners-and-hardware-resources
-#     #   - https://gh.io/using-larger-runners (GitHub.com only)
-#     # Consider using larger runners or machines with greater resources for possible analysis time improvements.
-#     runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
-#     permissions:
-#       # required for all workflows
-#       security-events: write
+jobs:
+  analyze:
+    name: Analyze (${{ matrix.language }})
+    # Runner size impacts CodeQL analysis time. To learn more, please see:
+    #   - https://gh.io/recommended-hardware-resources-for-running-codeql
+    #   - https://gh.io/supported-runners-and-hardware-resources
+    #   - https://gh.io/using-larger-runners (GitHub.com only)
+    # Consider using larger runners or machines with greater resources for possible analysis time improvements.
+    runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }}
+    permissions:
+      # required for all workflows
+      security-events: write
 
-#       # required to fetch internal or private CodeQL packs
-#       packages: read
+      # required to fetch internal or private CodeQL packs
+      packages: read
 
-#       # only required for workflows in private repositories
-#       actions: read
-#       contents: read
+      # only required for workflows in private repositories
+      actions: read
+      contents: read
 
-#     strategy:
-#       fail-fast: false
-#       matrix:
-#         include:
-#         - language: actions
-#           build-mode: none
-#         - language: javascript-typescript
-#           build-mode: none
-#         - language: python
-#           build-mode: none
-#         # CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'rust', 'swift'
-#         # Use `c-cpp` to analyze code written in C, C++ or both
-#         # Use 'java-kotlin' to analyze code written in Java, Kotlin or both
-#         # Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both
-#         # To learn more about changing the languages that are analyzed or customizing the build mode for your analysis,
-#         # see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning.
-#         # If you are analyzing a compiled language, you can modify the 'build-mode' for that language to customize how
-#         # your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages
-#     steps:
-#     - name: Checkout repository
-#       uses: actions/checkout@v4
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+        - language: actions
+          build-mode: none
+        - language: javascript-typescript
+          build-mode: none
+        - language: python
+          build-mode: none
+        # CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'rust', 'swift'
+        # Use `c-cpp` to analyze code written in C, C++ or both
+        # Use 'java-kotlin' to analyze code written in Java, Kotlin or both
+        # Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both
+        # To learn more about changing the languages that are analyzed or customizing the build mode for your analysis,
+        # see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning.
+        # If you are analyzing a compiled language, you can modify the 'build-mode' for that language to customize how
+        # your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v4
 
-#     # Add any setup steps before running the `github/codeql-action/init` action.
-#     # This includes steps like installing compilers or runtimes (`actions/setup-node`
-#     # or others). This is typically only required for manual builds.
-#     # - name: Setup runtime (example)
-#     #   uses: actions/setup-example@v1
+    # Add any setup steps before running the `github/codeql-action/init` action.
+    # This includes steps like installing compilers or runtimes (`actions/setup-node`
+    # or others). This is typically only required for manual builds.
+    # - name: Setup runtime (example)
+    #   uses: actions/setup-example@v1
 
-#     # Initializes the CodeQL tools for scanning.
-#     - name: Initialize CodeQL
-#       uses: github/codeql-action/init@v4
-#       with:
-#         languages: ${{ matrix.language }}
-#         build-mode: ${{ matrix.build-mode }}
-#         # If you wish to specify custom queries, you can do so here or in a config file.
-#         # By default, queries listed here will override any specified in a config file.
-#         # Prefix the list here with "+" to use these queries and those in the config file.
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v4
+      with:
+        languages: ${{ matrix.language }}
+        build-mode: ${{ matrix.build-mode }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
 
-#         # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
-#         # queries: security-extended,security-and-quality
+        # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+        # queries: security-extended,security-and-quality
 
-#     # If the analyze step fails for one of the languages you are analyzing with
-#     # "We were unable to automatically build your code", modify the matrix above
-#     # to set the build mode to "manual" for that language. Then modify this step
-#     # to build your code.
-#     # ℹ️ Command-line programs to run using the OS shell.
-#     # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
-#     - name: Run manual build steps
-#       if: matrix.build-mode == 'manual'
-#       shell: bash
-#       run: |
-#         echo 'If you are using a "manual" build mode for one or more of the' \
-#           'languages you are analyzing, replace this with the commands to build' \
-#           'your code, for example:'
-#         echo '  make bootstrap'
-#         echo '  make release'
-#         exit 1
+    # If the analyze step fails for one of the languages you are analyzing with
+    # "We were unable to automatically build your code", modify the matrix above
+    # to set the build mode to "manual" for that language. Then modify this step
+    # to build your code.
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+    - name: Run manual build steps
+      if: matrix.build-mode == 'manual'
+      shell: bash
+      run: |
+        echo 'If you are using a "manual" build mode for one or more of the' \
+          'languages you are analyzing, replace this with the commands to build' \
+          'your code, for example:'
+        echo '  make bootstrap'
+        echo '  make release'
+        exit 1
 
-#     - name: Perform CodeQL Analysis
-#       uses: github/codeql-action/analyze@v4
-#       with:
-#         category: "/language:${{matrix.language}}"
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v4
+      with:
+        category: "/language:${{matrix.language}}"

.github/workflows/python-package.yml

@@ -26,7 +26,35 @@
       run: |
         python -m pip install --upgrade pip
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
-        pip install pytest-cov
+        pip install pytest-cov pip-audit
     - name: Run tests
       run: |
-        pytest tests/ -v --tb=short -x -m "not network" --cov=agent_scripts --cov-report=term-missing
+        pytest tests/ -v --tb=short -m "not network" --cov=agent_scripts --cov-report=term-missing
+    - name: Audit Python dependencies for known CVEs
+      # Informational for now (continue-on-error) — flips to a hard gate once
+      # the existing dependency tree's known advisories are triaged.
+      continue-on-error: true
+      run: pip-audit -r requirements.txt
+
+  frontend:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: UI/frontend
+    steps:
+    - uses: actions/checkout@v4
+    - name: Set up Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version: '20'
+        cache: 'npm'
+        cache-dependency-path: UI/frontend/package-lock.json
+    - name: Install dependencies
+      run: npm ci
+    - name: Type-check
+      run: npx tsc --noEmit
+    - name: Build
+      run: npm run build
+    - name: Audit npm dependencies for known CVEs
+      continue-on-error: true
+      run: npm audit --audit-level=high

.gitignore

@@ -14,10 +14,12 @@
 # ==============================================================================
 # Project Directories & Data
 # ==============================================================================
-# Keep the input directory, but ignore all files inside it
-input/
-input/*
-!input/.gitkeep
+# Keep the inputs directory, but ignore all files inside it.
+# NOTE: this was previously "input/" (singular) — a typo that never matched
+# the real "inputs/" directory, which is why debug prompt/JSON dumps ended
+# up committed to the repo (see SECURITY.md).
+inputs/*
+!inputs/.gitkeep
 
 # Keep the output directory, but ignore all files inside it
 output/*
@@ -27,6 +29,10 @@ output/*
 tools/rl/weights/*
 !tools/rl/weights/.gitkeep
 
+# LSTM checkpoint cache (keyed by data fingerprint — see tools/dl/lstm_prediction.py)
+tools/dl/lstm_weights/*
+!tools/dl/lstm_weights/.gitkeep
+
 # Training-session run artifacts (keep the dir, ignore the JSON dumps)
 tools/rl/sessions/*
 !tools/rl/sessions/.gitkeep
@@ -43,8 +49,6 @@ buck_visualizer/data-viz/
 *.mcpb
 *.dxt
 
-# Documentation (kept local, not version-controlled)
-docs/
 
 # ==============================================================================
 # Python build / tooling