Skip to content

Conversation

@Deepam02
Copy link
Contributor

@Deepam02 Deepam02 commented Oct 7, 2025

Closes #113

Enhanced the UI to display real-time validation feedback when users enter a passphrase

Screen.Recording.2025-10-07.153042.mp4

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 40.51282% with 232 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/ui/passphrase.go 22.94% 176 Missing and 2 partials ⚠️
internal/encryption/passphrase/prompt.go 66.03% 50 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@Deepam02
Copy link
Contributor Author

Deepam02 commented Oct 7, 2025

@SubstantialCattle5
please review this pr

@S4tvara
Copy link
Owner

S4tvara commented Oct 8, 2025

image Can the reqd be mentioned below the passpharese text box? image Also there isn't any indiciation when we use the flag

@S4tvara
Copy link
Owner

S4tvara commented Oct 15, 2025

@Deepam02, are you still working on the issue?

@Deepam02
Copy link
Contributor Author

yes ,i got busy with some college activities, but I will finish it by tomorrow.

@S4tvara
Copy link
Owner

S4tvara commented Oct 16, 2025

@Deepam02 sure..

@github-actions
Copy link
Contributor

💡 Suggestions to Improve This PR

  • ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

}

if hasLength {
statusParts[0] = fmt.Sprintf("%s12+(%d)", getSymbol(hasLength), len(passphrase))

Check warning

Code scanning / gosec

slice index out of range Warning

slice index out of range
@Deepam02
Copy link
Contributor Author

Can the reqd be mentioned below the passpharese text box?

tried to do it but coudnt because Terminal-based prompts like promptui.Prompt don't naturally support displaying content below the input field while maintaining cursor position. The feedback clearing and repositioning logic is designed to update content above the cursor, so we placed requirements above the input instead.
That said, the UI has still been improved and should feel better.

Also there isn't any indication when we use the flag

the passphrase requirements are now displayed when the flag is used.

@Deepam02
Copy link
Contributor Author

@SubstantialCattle5 have you had a chance to review this.

@S4tvara
Copy link
Owner

S4tvara commented Oct 29, 2025

Hi @Deepam02 ,
Sorry will take me a bit more time.
Till then i'll add the relevant tags such that it counts towards your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add UI Feedback for Passphrase Validation

2 participants