feat: filter network interfaces in peer discovery#130
Open
AdityaK-github wants to merge 1 commit intoS4tvara:mainfrom
Open
feat: filter network interfaces in peer discovery#130AdityaK-github wants to merge 1 commit intoS4tvara:mainfrom
AdityaK-github wants to merge 1 commit intoS4tvara:mainfrom
Conversation
- Add --all-addresses flag to show all network interfaces - Filter out Docker, VPN, and virtual interfaces by default - Prioritize LAN addresses and localhost - Show simplified address format (IP:port) instead of multiaddr - Add summary for filtered addresses - Maintain backward compatibility with --all-addresses flag Resolves cluttered output issue with Docker bridges and virtual interfaces
Contributor
💡 Suggestions to Improve This PR
Consider addressing these points to make your contribution stronger. Thanks for contributing! |
1 similar comment
Contributor
💡 Suggestions to Improve This PR
Consider addressing these points to make your contribution stronger. Thanks for contributing! |
Author
|
I closed the previous PR as I was having some trouble with the CI pipeline. |
Author
|
Please review this. |
Owner
|
Hey, I think you haven't run the linter before pushing. |
Owner
You're getting this because your explanation is 20 chars or less |
Owner
Yea the files still haven't been formatted properly .
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Files
Resolves cluttered output issue with Docker bridges and virtual interfaces.