Skip to content

feat: filter network interfaces in peer discovery #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AdityaK-github wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: filter network interfaces in peer discovery #130

AdityaK-github wants to merge 1 commit into from

Conversation

@AdityaK-github
Copy link

@AdityaK-github AdityaK-github commented Oct 10, 2025 •
edited
Loading

  • Add --all-addresses flag to show all network interfaces
  • Filter out Docker, VPN, and virtual interfaces by default
  • Prioritize LAN addresses and localhost
  • Show simplified address format (IP:port) instead of multiaddr
  • Add summary for filtered addresses
  • Maintain backward compatibility with --all-addresses flag

Changes

  • Added --all-addresses flag
  • Filter out Docker (172.x.x.x) and VPN interfaces by default
  • Show simplified format: 192.168.0.133:39295 vs /ip4/192.168.0.133/tcp/39295
  • Display [+N more, use --all-addresses to show] for hidden addresses
  • Prioritize: LAN > localhost > IPv6, filter virtual interfaces

Files

  • address_filter.go - filtering logic
  • address_display.go - clean output formatting
  • cmd/discover.go - added flag integration
  • discovery_util.go - updated function signatures
  • Tests for filtering behavior

Resolves cluttered output issue with Docker bridges and virtual interfaces.

feat: filter network interfaces in peer discovery
c23c3d2 
- Add --all-addresses flag to show all network interfaces
- Filter out Docker, VPN, and virtual interfaces by default
- Prioritize LAN addresses and localhost
- Show simplified address format (IP:port) instead of multiaddr
- Add summary for filtered addresses
- Maintain backward compatibility with --all-addresses flag

Resolves cluttered output issue with Docker bridges and virtual interfaces
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

💡 Suggestions to Improve This PR

  • ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025

💡 Suggestions to Improve This PR

  • ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

@AdityaK-github
Copy link
Author

AdityaK-github commented Oct 10, 2025

I closed the previous PR as I was having some trouble with the CI pipeline.

@AdityaK-github
Copy link
Author

AdityaK-github commented Oct 11, 2025

Please review this.

@S4tvara
Copy link
Owner

S4tvara commented Oct 12, 2025

Hey, I think you haven't run the linter before pushing.

@S4tvara
Copy link
Owner

S4tvara commented Oct 13, 2025

💡 Suggestions to Improve This PR

  • ❌ Missing or minimal explanation of changes

Consider addressing these points to make your contribution stronger. Thanks for contributing!

You're getting this because your explanation is 20 chars or less

@S4tvara
Copy link
Owner

S4tvara commented Oct 15, 2025

image Yea the files still haven't been formatted properly .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AdityaK-github @S4tvara