Conversation
- Replace deprecated exportloopref with copyloopvar linter - Fix errcheck violations by handling deadline and encoding errors - Add constants package for repeated string literals - Fix formatting and import grouping issues - Resolve staticcheck nil pointer dereference issue - Configure more lenient linting rules for development workflow
- Fix importShadow violations in discovery_util.go by renaming parameters - Fix importShadow issues in manifest/builder.go and testutil/testutil.go - Fix importShadow issue in aesencryption/prompt.go - Enable importShadow checks in golangci-lint config for better code quality - Remove overly broad gocritic exclusions while keeping specific noise filters
- Fix importShadow in cmd/discover.go by renaming host parameter to h - Fix importShadow in internal/ui/message.go by renaming config parameter to cfg - Fix importShadow in internal/encryption/keys/rsa.go by renaming config parameter to cfg - All importShadow violations now resolved across the codebase
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
gosec found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.