Skip to content

Draft For review #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 68 commits into
base: master
Choose a base branch
from
Open

Draft For review #4

wants to merge 68 commits into from

Conversation

razekmh
Copy link

@razekmh razekmh commented Jan 28, 2025

No description provided.

razekmh and others added 30 commits January 24, 2025 14:42
…reate-with-unit,-route-and-ddd

Razekmh/1 merge omop drug lookup create with unit, route and ddd
…e-DDD

Razekmh/3 add a method to query the ddd
…ate-DDD

Razekmh/5 build a method to calculate ddd
razekmh and others added 19 commits February 10, 2025 19:35
This calcualtion works fine now but the
code is not very efficient. I will need to check
this later.
currently the drug_strengths table returns all the
ingredients associated with a drug. This is
a problem because not all ingredients are "antibiotics"
and we need to filter the list to only include
antibiotics.
- the user will need to specify the type of id they are using
- durg id will be the default
- I still need to fix the problem with finding the
correct active ingredient id for a drug id
Copy link
Collaborator

@andysouth andysouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @razekmh this looks really great ! Given how much work there is involved and the uncertainty in where to get the ddd data from I think it would be good to put this in a separate package. I can help to create a new package & repository. We would need to decide what to call the package. Does creating a new package seem like a good idea to you @stefpiatek ?

@razekmh
Copy link
Author

razekmh commented Feb 11, 2025

I do not have much experience in building packages in R but would be happy to learn. The code depends on the a few methods from omopcept and if we were to split it, I think I will need to either copy them or build similar ones. Any advice on the architecture is appreciated too.

@andysouth
Copy link
Collaborator

I can take you through package building - after I've reminded myself ;-) You've done the hard bits. We can get it to rely on omopcept so no need to copy functions :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants