-
Notifications
You must be signed in to change notification settings - Fork 2
Draft For review #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…reate-with-unit,-route-and-ddd Razekmh/1 merge omop drug lookup create with unit, route and ddd
…e-DDD Razekmh/3 add a method to query the ddd
…ate-DDD Razekmh/5 build a method to calculate ddd
This calcualtion works fine now but the code is not very efficient. I will need to check this later.
currently the drug_strengths table returns all the ingredients associated with a drug. This is a problem because not all ingredients are "antibiotics" and we need to filter the list to only include antibiotics.
Razekmh/7 add compute ddd func
- the user will need to specify the type of id they are using - durg id will be the default - I still need to fix the problem with finding the correct active ingredient id for a drug id
Razekmh/7 add compute ddd func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @razekmh this looks really great ! Given how much work there is involved and the uncertainty in where to get the ddd data from I think it would be good to put this in a separate package. I can help to create a new package & repository. We would need to decide what to call the package. Does creating a new package seem like a good idea to you @stefpiatek ?
I do not have much experience in building packages in R but would be happy to learn. The code depends on the a few methods from omopcept and if we were to split it, I think I will need to either copy them or build similar ones. Any advice on the architecture is appreciated too. |
I can take you through package building - after I've reminded myself ;-) You've done the hard bits. We can get it to rely on omopcept so no need to copy functions :-) |
add export to csv and date filter
No description provided.