This repository was archived by the owner on Mar 26, 2025. It is now read-only.
feat: middleware uses local resources when present#8
Open
vladitasev wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short version:
This changes the way
middlewarehandlesthirdparty/resource requests.Long version:
Every resource that matches the
reverseAliaseswas read fromnode_modules/and transpiled. Basically, this means that any request for the web components libraries that hasthirdparty/is assumed to be found innode_modules/as a dependency. While this is true for OpenUI5 itself (it has all@ui5/webcomponents*packages asdevDependency), this is not the case for third-party libraries: for these, the OpenUI5 monorepo is not a dependency (only individual OpenUI5 libraries are), therefore third-party libraries do not have@ui5/webcomponents*as any kind of dependency. As a result, middleware requests to@ui5/webcomponents-iconsand similar failed. This change fixes that by allowing the middleware to look for such files in the filesystem first. The third-party libraries will have@openui5/sap.ui.webc.commonas a dependency and will be able to find the files in itssrc-gendirectory as a result.