Open
Conversation
Maksimiliana
added
contribution
Hariharan-Gandhi
suggested changes
Mar 27, 2026
Contributor
Hariharan-Gandhi
left a comment
Hariharan-Gandhi
left a comment
There was a problem hiding this comment.
Improvement: (both in SAML and OIDC)
Required column shall contain either Yes or Optional
SAML Section:
Conditionally with a statement Required if enabled is set to true. sounds superfluous.
OIDC Section:
same comment.
Required should be Yes or Required uniform. We can decide on one.
We can remove Required if enabled is set to true. from all required fields and make a single entry under enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate OIDC as a single sign-on method into the prerequistes section