updated documentation for the language field #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schneidermic0
left a comment
schneidermic0
left a comment
There was a problem hiding this comment.
In general, looks good to me. 👍
Just one small comment/question (see below)
Co-authored-by: Michael Schneider <[email protected]>
Contributor
schneidermic0
left a comment
schneidermic0
left a comment
There was a problem hiding this comment.
Sorry, I missed an aspect, in my review, yesterday:
Co-authored-by: Michael Schneider <[email protected]>
Co-authored-by: Michael Schneider <[email protected]>
Member
Author
|
Just added a reference in json.md under the json.md now has a reference to languages.md and languages.md contains a full table of all supported language codes. |
albertmink
reviewed
Apr 12, 2024
Co-authored-by: Albert Mink <[email protected]>
schneidermic0
approved these changes
Apr 12, 2024
Contributor
schneidermic0
left a comment
schneidermic0
left a comment
There was a problem hiding this comment.
LGTM. Thanks, @Markus1812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates documentation according to changes made for #582 and adds a table for all supported languages and their BCP47 language code.
Follow up to #607