generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 7
[FEAT] reconcile Domains
and ClusterDomains
#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
skrishnan-sap
wants to merge
21
commits into
main
Choose a base branch
from
domains
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d67e7e6
to
227145f
Compare
Co-authored-by: Sathyajith Krishnan <[email protected]>
Add missing License and fix minor comment typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task List
Overall Status:
Domain
&ClusterDomain
reconciliation implemented and working. Refactoring, unit tests in progress.Domain
&ClusterDomain
.ingressSelector
.CAPApplication
status for use by domain resources. Requeue referenced domain resources in case of changes.spec.domainRefs
in theCAPApplication
.CAPApplications
.CAPApplication.spec.domainRefs
and (b) when a domain host change ina referenced domain resource is recognized fromCAPApplication
. This is required to keep theVirtualServices
up-to-date with the correct set of gateways and hosts.Notes
and
ClusterDomain`internal/controller/reconcile-domain.go
). To create reuseable functions an abstration interfacev1alpha1.DomainEntity
with common getter and setter methods has been created.Domains
and in the cap-operator namespace forClusterDomains
. This eliminates the need to identify ingress controller namespaces duringVirtualService
reconciliations.