Skip to content

Fix security vulnerabilities#1193

Open
mauriciolauffer wants to merge 3 commits intoSAP:masterfrom
mauriciolauffer:master
Open

Fix security vulnerabilities#1193
mauriciolauffer wants to merge 3 commits intoSAP:masterfrom
mauriciolauffer:master

Conversation

@mauriciolauffer
Copy link

Bump dependencies to address security vulnerabilities.

Executing $ npm audit returns 0 vulnerabilities now.

@mauriciolauffer
Copy link
Author

Supporting node 12-15 versions isn't required anymore, these tests could be removed.
image

@littleamigo
Copy link

Supporting node 12-15 versions isn't required anymore, these tests could be removed. image

Where are the tests for node 22 and 24?

@mauriciolauffer
Copy link
Author

mauriciolauffer commented Feb 11, 2026

@littleamigo my guess is they don't exist as I couldn't find them in the CircleCI config

PS: right now, v24 might be covered by the node:lts image, but I'm not sure because I didn't check it

@cla-assistant
Copy link

cla-assistant bot commented Feb 12, 2026

CLA assistant check
All committers have signed the CLA.

@littleamigo
Copy link

littleamigo commented Feb 17, 2026

fixes CVE-2026-25639
fixes #1190

@littleamigo
Copy link

@kbarnold Would you be so nice and review/merge this fix and then release a new image on docker hub?

@littleamigo
Copy link

@kbarnold Coveralls is down (Outage) and hence the build fails. Please hold until they restored the service and then re-run the build.

@kbarnold
Copy link
Collaborator

@littleamigo Thanks for the info. I'm planning to merge this and a few other PRs but want to include Node 22 and 24 in the tests before.
Removal of the old Node versions should be done separately. It probably makes sense to remove them altogether, not just from the tests.

@littleamigo
Copy link

@kbarnold Coveralls is restored and fully functional again. You can re-trigger the build at https://app.circleci.com/pipelines/github/SAP/cloud-mta-build-tool/1202/workflows/6290489a-f3cb-47cf-8f1a-0d440cc7d772/jobs/8664.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants