Skip to content

Update CycloneDX Maven plugin version to 2.9.0#1198

Open
o-liver wants to merge 1 commit intoSAP:masterfrom
o-liver:patch-1
Open

Update CycloneDX Maven plugin version to 2.9.0#1198
o-liver wants to merge 1 commit intoSAP:masterfrom
o-liver:patch-1

Conversation

@o-liver
Copy link
Member

@o-liver o-liver commented Feb 17, 2026

Description

The older version is not java 21 compatible. We see the following error:

Error: Failed to execute goal org.cyclonedx:cyclonedx-maven-plugin:2.7.5:makeAggregateBom (default-cli) on project btc-cross-healthcheck-srv: Execution default-cli of goal org.cyclonedx:cyclonedx-maven-plugin:2.7.5:makeAggregateBom failed: Unsupported class file major version 65 -> [Help 1]

Checklist

  • Code compiles correctly
  • Relevant tests were added (unit / contract / integration)
  • Relevant logs were added
  • Formatting and linting run locally successfully
  • All tests pass
  • UA review
  • Design is documented
  • Extended the README / documentation, if necessary
  • Open source is approved

The older version is not java 21 compatible
@littleamigo
Copy link

@kbarnold Would you be so nice and review/merge this fix and then release a new image on docker hub?

@o-liver
Copy link
Member Author

o-liver commented Feb 18, 2026

The thing is that this issue existed before the last release. If you look at git blame this was introduced with a lower version than the non-custom case 11 months ago. I don't know the reason for that? Why was it not simply copied from the non-custom case 10 lines above? Maybe there is a reason and we should not change it 🤔

@o-liver
Copy link
Member Author

o-liver commented Feb 18, 2026

In any case, for all custom build users there is a workaround (according to AI, did not test it myself!) by setting the sbom-create-commands parameter at the right place in the mta.yaml, e.g.:

modules:
  - name: your-module
    type: java
    build-parameters:
      builder: custom
      sbom-create-commands:
        - mvn org.cyclonedx:cyclonedx-maven-plugin:2.9.0:makeAggregateBom -DschemaVersion=1.4 -DincludeBomSerialNumber=true -DincludeCompileScope=true -DincludeRuntimeScope=true -DincludeSystemScope=true -DincludeTestScope=false -DincludeLicenseText=false -DoutputFormat=xml -DoutputName=${sbom-file-name}

It would be great if people could test this and report back here if it works for them. That would also give us a heads-up whether this solution works at all.

@o-liver
Copy link
Member Author

o-liver commented Feb 18, 2026

The thing is that this issue existed before the last release. If you look at git blame this was introduced with a lower version than the non-custom case 11 months ago. I don't know the reason for that? Why was it not simply copied from the non-custom case 10 lines above? Maybe there is a reason and we should not change it 🤔

Ok, now I got it: This was never released. It comes from this huge PR #1154 that was never released and thus never field tested. Who knows what else went into the master and then just lay about before this release more than one year later 😦

@wlsc
Copy link

wlsc commented Feb 18, 2026

The thing is that this issue existed before the last release. If you look at git blame this was introduced with a lower version than the non-custom case 11 months ago. I don't know the reason for that? Why was it not simply copied from the non-custom case 10 lines above? Maybe there is a reason and we should not change it 🤔

I know the answer here: yes, it was introduced 11 month ago, but latest build until the recent fix that got released was more than 1 year ago in November or so 2024

@littleamigo
Copy link

Are we going to merge the fix or not? If so, what's stopping us from merging it soon?

@o-liver
Copy link
Member Author

o-liver commented Feb 19, 2026

It needs an approval from a person with the right authority.

@littleamigo
Copy link

I hope Ken picks it up soon 🙇

@kbarnold
Copy link
Collaborator

I hope Ken picks it up soon 🙇

I want to have this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants