fix: entitlement external resource got deleted when it should be updated#600
Merged
enrico-kaack-comp merged 3 commits intomainfrom Apr 15, 2026
Merged
fix: entitlement external resource got deleted when it should be updated#600enrico-kaack-comp merged 3 commits intomainfrom
enrico-kaack-comp merged 3 commits intomainfrom
Conversation
On-behalf-of: David Siregar <david.siregar@sap.com> Signed-off-by: David Siregar <david.siregar@sap.com>
dattito
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
dattito
added
the
release-notes/bugfix
Contributor
Author
|
FYI @jtucci |
enrico-kaack-comp
approved these changes
Mar 27, 2026
Contributor
enrico-kaack-comp
left a comment
enrico-kaack-comp
left a comment
There was a problem hiding this comment.
thank you for picking this out of the bigger PR.
Did you manually test this behaviour? Do you want to add unit tests for this?
Contributor
Author
|
@enrico-kaack-comp I tested it manually. Writing unit tests is hard because it requires communication with the BTP server that would need to be mocked in a complicated manner. Also doing e2e testing this is very hard, because you try to observe that a certain event is not happening. |
Contributor
|
on quick glance the communication with the btp should be mockable since the client already has a mock client. But your call how you want to proceed, you are more in the code than me |
On-behalf-of: David Siregar <david.siregar@sap.com> Signed-off-by: David Siregar <david.siregar@sap.com>
dattito
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
Contributor
Author
|
@enrico-kaack-comp you are right, it is indeed possible to mock them. I added some relevant unit tests. |
enrico-kaack-comp
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
jtucci
pushed a commit
to jtucci/crossplane-provider-btp
that referenced
this pull request
Apr 24, 2026
…ted (SAP#600) On-behalf-of: David Siregar <david.siregar@sap.com> Signed-off-by: David Siregar <david.siregar@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597.
Cherry-picked the commit from #527.