Conversation
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
force-pushed
the
feat/export-tool
branch
from
c3d3ab0 to
8ed82c5
Compare
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
force-pushed
the
feat/export-tool
branch
from
e0097b2 to
370e439
Compare
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
force-pushed
the
feat/export-tool
branch
from
5867dd7 to
8c61c62
Compare
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
sdischer-sap
left a comment
sdischer-sap
left a comment
There was a problem hiding this comment.
Looks great.
I noticed that tests are missing. Also we should probably have some developer centric documentation for that (explaining "how to add export support for a new resource").
Can be follow ups I guess, but we should have tickets for that. Not sure if we do.
|
|
||
| <a id="installation"></a> | ||
|
|
||
| # TODO Installation |
There was a problem hiding this comment.
This chapter will be filled in when #121 is implemented.
| @@ -0,0 +1,574 @@ | |||
| # Introduction | |||
There was a problem hiding this comment.
Nice docs, maybe we should link them from main README?
|
|
||
| import ( | ||
| "context" | ||
| "log/slog" |
There was a problem hiding this comment.
I guess we are using a different library for logging here compared to the rest of the provider right?
Is that technically required?
There was a problem hiding this comment.
The logging comes from xp-clifford, which aimed to use the most advanced, non-third-party logging framework. I hope the provider will eventually follow this path...
|
Does this PR belong to a particular issue? |
I linked the relevant issues. |
argh this github tools confuse me. I am still used to putting a ref in the Description. Always forget to check the UI, but thats fine then. |
Unit test for a CLI tool is not obvious. We want to have e2e test, see #198. |
I created #199. |
I mean, I linked them after your comment. |
gergely-szabo-sap
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
3 participants
This PR adds a new binary tool. It is an export CLI tool that can export resource definitions from a Cloud Foundry system in the format of the Cloud Foundry provider's custom resource definitions.