fix: add pollInterval to remaining controllers#207
Open
maximilianbraun wants to merge 1 commit intomainfrom
Open
fix: add pollInterval to remaining controllers#207maximilianbraun wants to merge 1 commit intomainfrom
maximilianbraun wants to merge 1 commit intomainfrom
Conversation
- Added managed.WithPollInterval(o.PollInterval) to 5 controllers: - app - domain - org - orgrole - spacerole - Bumped version from 1.0.0-rc1 to 1.0.0-rc2 This ensures all 14 controllers now properly configure poll intervals for resource reconciliation, aligning with ecosystem standards. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Maximilian Braun (SAP) <maximilian.braun@sap.com>
maximilianbraun
had a problem deploying
to
pr-e2e-no-approval
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
managed.WithPollInterval(o.PollInterval)to 5 controllers that were missing it:Background
Poll interval configuration allows controllers to specify how frequently they reconcile resources. This ensures consistent reconciliation timing across all 14 controllers (9 already had it, 5 were missing).
Testing
Risk
Low - adding missing configuration that other controllers already use.