Skip to content

feat: Add service instance sharing#219

Merged
lennardrother merged 21 commits intomainfrom
feat/service-instance-sharing
Apr 10, 2026
Merged

feat: Add service instance sharing#219
lennardrother merged 21 commits intomainfrom
feat/service-instance-sharing

Conversation

@lennardrother
Copy link
Copy Markdown
Collaborator

@lennardrother lennardrother commented Mar 9, 2026 •
edited
Loading

Summary

Closes #209

Adds support for CF service instance sharing, allowing a ServiceInstance to be shared with additional Cloud Foundry spaces via the new sharedSpaces field.

  • API: Added sharedSpaces []SpaceReference to ServiceInstanceParameters, allowing users to declare which spaces a service instance should be shared with
  • Client: Added AreSharedSpacesUpToDate, UpdateSharedSpaces, and helper functions to compute and reconcile the diff between desired and current shared spaces
  • Controller: Integrated shared space reconciliation into the observe, create, and update flows
  • Tests: Unit tests for client-level sharing logic (diff, share, unshare) and controller-level reconciliation; E2E test coverage for shared service instances
  • Example: Added examples/serviceinstance/service_instance_shared.yaml

@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 9, 2026 10:49 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 9, 2026 13:48 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 9, 2026 14:28 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 10, 2026 08:43 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 10, 2026 10:29 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 13, 2026 10:01 — with GitHub Actions Inactive
@lennardrother lennardrother force-pushed the feat/service-instance-sharing branch from 0484a93 to 25c4ae3 Compare March 13, 2026 10:10
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 13, 2026 10:13 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 13, 2026 12:28 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 16, 2026 14:51 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 16, 2026 15:07 — with GitHub Actions Inactive
@lennardrother lennardrother force-pushed the feat/service-instance-sharing branch from 9722aad to 18780d5 Compare March 16, 2026 15:09
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 16, 2026 15:09 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 16, 2026 15:24 — with GitHub Actions Inactive
@SatabdiG SatabdiG temporarily deployed to pr-e2e-no-approval March 17, 2026 10:45 — with GitHub Actions Inactive
@SatabdiG SatabdiG temporarily deployed to pr-e2e-no-approval March 17, 2026 13:27 — with GitHub Actions Inactive
@SatabdiG SatabdiG temporarily deployed to pr-e2e-no-approval March 17, 2026 13:42 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 17, 2026 13:57 — with GitHub Actions Inactive
@lennardrother lennardrother marked this pull request as ready for review March 17, 2026 14:07
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 20, 2026 09:19 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 20, 2026 09:26 — with GitHub Actions Inactive
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 20, 2026 09:28 — with GitHub Actions Inactive
SatabdiG
SatabdiG reviewed Mar 20, 2026
View reviewed changes
Comment thread internal/clients/serviceinstance/serviceinstance.go Outdated
SatabdiG
SatabdiG reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀 , mostly nits and some comments

Comment thread internal/clients/serviceinstance/serviceinstance.go
Comment thread internal/controller/serviceinstance/controller.go Outdated
Comment thread internal/controller/serviceinstance/controller.go Outdated
Comment thread internal/controller/serviceinstance/controller.go Outdated
Comment thread internal/controller/serviceinstance/controller.go Outdated
Comment thread internal/controller/serviceinstance/controller_test.go Outdated
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval March 23, 2026 09:34 — with GitHub Actions Inactive
@lennardrother lennardrother requested a review from SatabdiG March 23, 2026 13:38
SatabdiG
SatabdiG approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lennardrother lennardrother mentioned this pull request Mar 26, 2026
Closed
@lennardrother
Copy link
Copy Markdown
Collaborator Author

lennardrother commented Mar 26, 2026

Waiting for stakeholder feedback

@lennardrother lennardrother added the release-notes/new-feature Marks PR as new feature for release note generation label Apr 9, 2026
@lennardrother lennardrother temporarily deployed to pr-e2e-no-approval April 9, 2026 12:46 — with GitHub Actions Inactive
@lennardrother lennardrother merged commit 8b8cd25 into main Apr 10, 2026
12 checks passed
@lennardrother lennardrother deleted the feat/service-instance-sharing branch April 10, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SatabdiG SatabdiG SatabdiG approved these changes

@sdischer-sap sdischer-sap Awaiting requested review from sdischer-sap

Assignees

No one assigned

Labels

release-notes/new-feature Marks PR as new feature for release note generation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for CF instance sharing

2 participants

@lennardrother @SatabdiG