Skip to content

chore(deps): update xp-clifford to v0.0.0-20260312105548-6c739d63b4f1#222

Merged
gergely-szabo-sap merged 2 commits intomainfrom
chore/upgrade-clifford-dependency
Mar 16, 2026
Merged

chore(deps): update xp-clifford to v0.0.0-20260312105548-6c739d63b4f1#222
gergely-szabo-sap merged 2 commits intomainfrom
chore/upgrade-clifford-dependency

Conversation

@gergely-szabo-sap
Copy link
Copy Markdown
Contributor

@gergely-szabo-sap gergely-szabo-sap commented Mar 12, 2026

Description

This PR migrates from generic mkcontainer.Container to typed mkcontainer.TypedContainer[T] for improved type safety.

Changes

  • userrole.go: Migrated roleCache and userCache from mkcontainer.Container to mkcontainer.TypedContainer[*Role] and mkcontainer.TypedContainer[*user]
  • orgrole.go: Removed unnecessary type assertion since container now returns typed values
  • spacerole.go: Removed unnecessary type assertion since container now returns typed values
  • Dependencies: Updated xp-clifford to latest version

Motivation

The generic container required runtime type assertions which are now unnecessary with typed containers. This improves type safety and eliminates potential runtime type errors.

Testing

  • Existing tests pass
  • Code compiles successfully

Copy link
Copy Markdown
Collaborator

@Kukkerem Kukkerem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SatabdiG SatabdiG temporarily deployed to pr-e2e-approval March 13, 2026 14:04 — with GitHub Actions Inactive
@gergely-szabo-sap gergely-szabo-sap merged commit fefedd3 into main Mar 16, 2026
12 checks passed
@gergely-szabo-sap gergely-szabo-sap deleted the chore/upgrade-clifford-dependency branch March 16, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants