Skip to content

SpaceRole External-Name Handling#252

Merged
AndresNico merged 9 commits intomainfrom
task/251
Apr 17, 2026
Merged

SpaceRole External-Name Handling#252
AndresNico merged 9 commits intomainfrom
task/251

Conversation

@AndresNico
Copy link
Copy Markdown
Collaborator

@AndresNico AndresNico commented Apr 8, 2026 •
edited
Loading

Closes: #251

  1. Implemented correct external-name handling in Create and Delete function
  2. Adapted Unit Tests for Create and Delete function
  3. Created E2E Import Test
    • Added workflow step to set BUILD_ID env var and include it as variable
    • Added utils for E2E Import Test
  4. Created Upgrade Test for External-Name Behavior
  5. Added documentation

@AndresNico AndresNico temporarily deployed to pr-e2e-no-approval April 8, 2026 08:47 — with GitHub Actions Inactive
@AndresNico AndresNico temporarily deployed to pr-e2e-no-approval April 9, 2026 09:32 — with GitHub Actions Inactive
@AndresNico AndresNico temporarily deployed to pr-e2e-no-approval April 9, 2026 13:10 — with GitHub Actions Inactive
@AndresNico AndresNico temporarily deployed to pr-e2e-no-approval April 10, 2026 12:44 — with GitHub Actions Inactive
@AndresNico AndresNico marked this pull request as ready for review April 13, 2026 08:10
@AndresNico AndresNico temporarily deployed to pr-e2e-no-approval April 13, 2026 08:19 — with GitHub Actions Inactive
SatabdiG
SatabdiG reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, some reviews from my side

Comment thread internal/controller/spacerole/controller.go
Comment thread internal/controller/spacerole/controller.go
Comment thread internal/controller/spacerole/controller_test.go
Comment thread test/e2e/import_utils.go Outdated
Comment thread test/e2e/import_utils.go Outdated
@AndresNico AndresNico temporarily deployed to pr-e2e-no-approval April 15, 2026 10:13 — with GitHub Actions Inactive
@AndresNico AndresNico requested a review from SatabdiG April 15, 2026 10:33
SatabdiG
SatabdiG approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AndresNico AndresNico merged commit 6844b56 into main Apr 17, 2026
12 checks passed
@AndresNico AndresNico deleted the task/251 branch April 17, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SatabdiG SatabdiG SatabdiG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TASK] External Name (SpaceRole): Ensure ADR Compliance

2 participants

@AndresNico @SatabdiG