Skip to content

Route External-Name Handling#259

Open
Kukkerem wants to merge 4 commits intomainfrom
external-name-comp-route
Open

Route External-Name Handling#259
Kukkerem wants to merge 4 commits intomainfrom
external-name-comp-route

Conversation

@Kukkerem
Copy link
Copy Markdown
Collaborator

@Kukkerem Kukkerem commented Apr 22, 2026

Closes: #244

  1. Implemented correct external-name handling in Create and Delete function
  2. Adapted Unit Tests for Create and Delete function
  3. Created E2E Import Test
  4. Created Upgrade Test for External-Name Behavior
  5. Added documentation

@Kukkerem
feat(routes): implement ADR-compliant external-name handling
0a906e0 
Signed-off-by: Zoltan Szabo <zoltan.szabo03@sap.com>
@Kukkerem Kukkerem requested a review from SatabdiG April 22, 2026 09:13
@Kukkerem Kukkerem self-assigned this Apr 22, 2026
SatabdiG
SatabdiG approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

@Kukkerem
fix(route): implement SpaceScoped interface for space name resolution
03d3eb8 
Signed-off-by: Zoltan Szabo <zoltan.szabo03@sap.com>
@Kukkerem Kukkerem temporarily deployed to pr-e2e-approval April 23, 2026 14:15 — with GitHub Actions Inactive
@Kukkerem Kukkerem temporarily deployed to pr-e2e-no-approval April 27, 2026 14:47 — with GitHub Actions Inactive
@Kukkerem Kukkerem temporarily deployed to pr-e2e-no-approval April 27, 2026 15:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SatabdiG SatabdiG SatabdiG approved these changes

Assignees

@Kukkerem Kukkerem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TASK] External Name (Route): Ensure ADR Compliance

2 participants

@Kukkerem @SatabdiG