Conversation
Lasserich
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
gergely-szabo-sap
approved these changes
May 13, 2025
Contributor
gergely-szabo-sap
left a comment
gergely-szabo-sap
left a comment
There was a problem hiding this comment.
lgtm
I have two non-blocking comments:
- The release-candidate workflow has shared parts with the release workflow. Those could be (eventually) factored out to a shared action.
- This PR also solves the stuck domain issue during e2e tests. Ideally, there should be another PR for this ;)
Contributor
Author
|
Acknowledged! Thanks for reviewing I will put the concerns in the description so we don't loose track of it. |
Lasserich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows us to publish tagged images of a branch.
For further discussion look here:
https://github.com/SAP/crossplane-provider-btp/pull/138/files
This is needed for the upcoming TechTalk, where we want to enable users to directly try out MTAs without having it build into the main branch yet.
The release-candidate workflow has shared parts with the release workflow. Those could be (eventually) factored out to a shared action