Fix: Wait for build result before opening submodule update PRs#38
Merged
Conversation
enrico-kaack-comp
approved these changes
Apr 1, 2026
| // GitHub suppresses them to prevent infinite loops. We dispatch | ||
| // the build manually and wait for it to finish before opening the | ||
| // PR, so the PR body already shows the final build status. | ||
| await github.rest.actions.createWorkflowDispatch({ |
There was a problem hiding this comment.
be careful that this is not an attack vector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Wait for build result before opening submodule update PRs
Previously,
update-submodule.yamlopened the PR immediately and then dispatchedthe build separately — relying on
workflow_runto update the PR body afterwards.This was unreliable:
workflow_rundoes not fire forworkflow_dispatchruns onnon-default branches, so the PR body stayed at
⏳ pendingforever.New approach: The build is dispatched before the PR is opened. The workflow
polls for the result (every 20s, up to 10 min), then opens the PR with the final
status (
✅ passed,❌ failed, or⚠️ unknown) already in the body.Changes
update-submodule.yaml: Dispatch build → poll for result → open PR withfinal status. Removed the separate "Trigger test build" step.
test-build.yaml: Reverted to its original state — no longer needspull-requests: writeor the inline PR body update step.update-pr-build-status.yaml: Deleted — fully superseded by the newsynchronous approach.