docs: documentation refresh#14160
Open
MariaIDineva wants to merge 9 commits intomainfrom
Open
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #14157
Description
README.md
Removed:
Added/rewritten:
Fixed the NEW_COMPONENT.md contributing link (file now exists)
NEW_COMPONENT.md
libs/docs/GETTING_STARTED.md (Home Page)
libs/datetime-adapter/README.md
libs/moment-adapter/README.md
libs/ui5-webcomponents-base/README.md
libs/nx-plugin/README.md
nx build webc-generator && nx run webc-generator:generatecommand which said it would regenerate the wrappers but would only actually regeneratewebcomponents-aipackage and would exit with an error. No we have the correct command in place -nx build webc-generator && nx run-many -t generate -p ui5-webcomponents ui5-webcomponents-fiori ui5-webcomponents-ai.generatetarget inwebc-generator/project.jsonthat was used in the misleading command mentioned above.libs/webc-generator/README.md
Some bugfixes:
sap-component generator — add-entry-to-api-files.ts
api-files.ts uses as const, which SWC wraps in a TsConstAssertion node rather than a plain ObjectExpression. The code assumed .init was directly an ObjectExpression, so .properties was undefined. Fixed by unwrapping TsConstAssertion.expression before accessing .properties.
sap-component generator — add-entry-to-docs-routes.ts
SWC 1.5.7 added a required phase field to Import AST nodes (dynamic import() expressions). The manually-constructed AST was missing phase: 'evaluation', causing printSync to fail with missing field 'phase'.