Set webview debugging if gigya logger is in debug mode similar to iOS #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS, there is implementation to automatically set the
isInspectablevalue of theWKWebViewastrueof the NSS WebView if the build is inDEBUGmode and ifGigyaLogger.isDebug()returnstrue. This is is not the case for the Android SDK. This PR updates the Android implementation to match iOS so the same solution can be used for both platforms on the gigya-flutter-plugin.We are using the gigya-flutter-plugin and I have created a PR to make use of this functionality as we are unable to access the WEBVIEW context when using the Appium Flutter driver to build some integration tests. But in the gigya-flutter-plugin the implementations on iOS and Android need to be different as setting the GigyaLogger to Debug mode is not sufficient to enable debugging of the WebView.