enh : enable map merge insertion of documents#74
Open
VarinThakur01 wants to merge 8 commits intomainfrom
Open
Conversation
* enh: enable map_merge to add_texts in vectorstore * remove print statements * add example documentation * drop tables when error is thrown and add uid * uplift temp table name into a variable * update tests, example and allow map merge only as a kw argument * reduce nesting and remove redundant param
This reverts commit 1deae29.
…meterise model id
VarinThakur01
changed the title
yonarw
approved these changes
Apr 15, 2026
Contributor
yonarw
left a comment
yonarw
left a comment
There was a problem hiding this comment.
Only some smaller formatting issues that my linter is showing. Maybe we can add
[tool.ruff.format]
quote-style = "double"
indent-style = "space"to pyproject.toml. But we can do that in a followup PR that'll format each file once to make everything consistent in the repo and afterward "enforce" it via a CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds insertion of documents through the MAP MERGE SQL approach.
Builds up on #69 as it had some open issues.