[FIX] fileUtils: Correctly provide stat property on readFile result and properly handle exceptions from fs.stat#382
Open
RandomByte wants to merge 2 commits intomainfrom
Open
[FIX] fileUtils: Correctly provide stat property on readFile result and properly handle exceptions from fs.stat#382RandomByte wants to merge 2 commits intomainfrom
RandomByte wants to merge 2 commits intomainfrom
Conversation
The fileInfo object contains property 'stat', not 'stats'. I couldn't find any usage of the property on the readFile result though.
matz3
previously approved these changes
Dec 2, 2024
RandomByte
force-pushed
the
fix-readFile-stat
branch
3 times, most recently
from
d382253 to
3c37f2a
Compare
RandomByte
changed the title
RandomByte
changed the title
Do not assume every exception is caused by a missing file
RandomByte
force-pushed
the
fix-readFile-stat
branch
from
3c37f2a to
f90f58a
Compare
matz3
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fileInfo object contains property 'stat', not 'stats'. I couldn't find any usage of the property on the readFile result though.
Also, do not assume every fs.stat exception is caused by a missing file.
NOTE: UI5 Tooling v4 relies on the current behavior in the sense that it does not always pass an
ENOENTerror code to the less-openui5 file system callback. Therefore this should be released as part of a new minor version of less-openui5 (implying a breaking change).